On Fri, Nov 18, 2022 at 04:14:54PM +0800, Yang Yingliang wrote:
> I got the the following report:
>
> OF: ERROR: memory leak, expected refcount 1 instead of 2,
> of_node_get()/of_node_put() unbalanced - destroy cset entry:
> attach overlay node /i2c/pmic@34/tcpc/connector
>
> The 'fwnode' set in tcpci_parse_config(), its node refcount is
> increased in device_get_named_child_node(). It needs be put while
> exiting, so call fwnode_handle_put() in the error path of
> tcpci_register_port() and in tcpci_remove() to avoid leak.
>
> Fixes: 5e85a04c8c0d ("usb: typec: add fwnode to tcpc")
> Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>
Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> ---
> drivers/usb/typec/tcpm/tcpci.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/tcpm/tcpci.c b/drivers/usb/typec/tcpm/tcpci.c
> index b2bfcebe218f..ade0a53b40ef 100644
> --- a/drivers/usb/typec/tcpm/tcpci.c
> +++ b/drivers/usb/typec/tcpm/tcpci.c
> @@ -794,8 +794,10 @@ struct tcpci *tcpci_register_port(struct device *dev, struct tcpci_data *data)
> return ERR_PTR(err);
>
> tcpci->port = tcpm_register_port(tcpci->dev, &tcpci->tcpc);
> - if (IS_ERR(tcpci->port))
> + if (IS_ERR(tcpci->port)) {
> + fwnode_handle_put(tcpci->tcpc.fwnode);
> return ERR_CAST(tcpci->port);
> + }
>
> return tcpci;
> }
> @@ -857,6 +859,7 @@ static void tcpci_remove(struct i2c_client *client)
> dev_warn(&client->dev, "Failed to disable irqs (%pe)\n", ERR_PTR(err));
>
> tcpci_unregister_port(chip->tcpci);
> + fwnode_handle_put(chip->tcpci->tcpc.fwnode);
> }
>
> static const struct i2c_device_id tcpci_id[] = {
> --
> 2.25.1
>
