On Fri, Oct 28, 2022 at 10:56:56AM +1100, Reka Norman wrote: > On Thu, Oct 27, 2022 at 5:11 PM Greg Kroah-Hartman > <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > > > On Thu, Oct 27, 2022 at 04:34:07PM +1100, Reka Norman wrote: > > > ADL-N systems have the same issue as ADL-P, where a large boot firmware > > > delay is seen if USB ports are left in U3 at shutdown. So apply the > > > XHCI_RESET_TO_DEFAULT quirk to ADL-N as well. > > > > > > This patch depends on "xhci: Add quirk to reset host back to default > > > state at shutdown". > > > > What is the git commit id of that change? > > It hasn't been merged in mainline yet, only in the xhci tree: > https://git.kernel.org/pub/scm/linux/kernel/git/mnyman/xhci.git/commit/?id=feb0b04b09c82589af65c84398b7d3fefaa7b7ac&head=for-usb-linus > Should I add the commit id from there? Or add the lore link? This is in linux-next already as 34cd2db408d5 ("xhci: Add quirk to reset host back to default state at shutdown") right? Please use that. > > And is this needed in stable kernels? If so, how far back? > > Sorry, I'm not sure how to answer that properly. > It looks like most ADL-N support was added starting from 5.16. > The issue it fixes is a ~20s boot delay in the specific case of booting from S5. > It probably makes sense for it to go wherever the ADL-P patch goes. Then properly mark it with that information. thanks, greg k-h
