Re: [PATCH 1/2] ehci: Fix IST boundary checking interval math.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 9 Oct 2009, Sarah Sharp wrote:

> When the EHCI driver falls behind in its scheduling, the active stream's
> first empty microframe may be in the past with respect to the current
> microframe.  The code attempts to move the starting microframe ("start") N
> number of microframes forward, where N is the interval of endpoint.
> However, stream->interval is a copy of the endpoint's bInterval, which is
> designated in frames for FS devices, and microframes for HS devices.
> Convert stream->interval to microframes before using it to move the
> starting microframe forward.
> 
> Signed-off-by: Sarah Sharp <sarah.a.sharp@xxxxxxxxxxxxxxx>
> CC: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> 
> Signed-off-by: Sarah Sharp <sarah.a.sharp@xxxxxxxxxxxxxxx>

Yep, this is another bug.  It's a good thing somebody is finally giving 
this code a close inspection -- it obviously needs one.

Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux