On 12/09/2022 01:59, Andre Przywara wrote:
Thank you for your patch. There is something to discuss/improve.
> clocks:
> + minItems: 4
> items:
> - description: USB OTG PHY bus clock
> - description: USB Host 0 PHY bus clock
> - description: USB Host 1 PHY bus clock
> - description: USB Host 2 PHY bus clock
> + - description: PMU clock for host port 2
>
> clock-names:
> + minItems: 4
> items:
> - const: usb0_phy
> - const: usb1_phy
> - const: usb2_phy
> - const: usb3_phy
> + - const: pmu2_clk
>
> resets:
> items:
> @@ -98,6 +102,21 @@ required:
>
> additionalProperties: false
>
> +if:
Please enclose it within allOf: block. Helps to reduce indentation
changes later when this grows.
> + properties:
> + compatible:
> + contains:
> + enum:
> + - sun50i-h616-usb-phy
> +
> +then:
> + properties:
> + clocks:
> + minItems: 5
> +
> + clock-names:
> + minItems: 5
I assume other variants do not have this clock? If correct, then:
else:
clocks:
maxItems: 4
and the same for clock-names
> +
> examples:
> - |
> #include <dt-bindings/gpio/gpio.h>
Best regards,
Krzysztof
