On 28.07.22 10:40, Hayes Wang wrote:
> Oliver Neukum <oneukum@xxxxxxxx>
>>> Date: Wed, 27 Jul 2022 13:29:42 +0200
>>> Subject: [PATCH] r8152: restore external MAC in reset_resume
>>>
>>> If user space has set the MAC of the interface,
>>> reset_resume() must restore that setting rather
>>> than redetermine the MAC like if te interface
>>> is probed regularly.
>
> I think this patch conflicts with commit 25766271e42f ("r8152: Refresh
> MAC address during USBDEVFS_RESET"). The results would be changed.
Argh.
OK, thank you. Do you agree that a manually set MAC needs to be kept
even through a pre/post_reset() and reset_resume(), while a MAC passed
through needs to be reevaluated at pre/post_reset() but not at
reset_resume()
> Besides, I don't understand why you set tp->external_mac = false
> in rtl8152_down().
Frankly I need to undo the effect of ndo_set_mac_address()
at some time, but it is unclear to me how to return a network
interface to its "native" MAC.
Any ideas?
Regards
Oliver
