> Of course -- the "with low latency set" part fell out (or, was implicit > ;-) ). Your patch, however, still has low_latency set when it calls > tty_flip_buffer_push and that's the problem. I don't think it does - I removed all the low latency setting. > How about unifying them to all use a single flag field (with two flags) > in usb_serial_port? May make sense. > > > > + * The per character mucking around with sysrq path it too slow, so > > > + * shortcircuit it in the 99.9999999% of cases where the USB serial is > > > + * not a console anyway. > > > + */ > > > + ch = packet + 2; > > > + len -= 2; > > > + if (!port->console || !port->sysrq) > > > > You need && flag == TTY_NORMAL ? > > You tell me. :-) Are we interested in them unless port->console is set? Yes - we don;t care about the sysrq but we care about error characters being reported ot the line discipline properly. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
