Re: [PATCH v16 2/3] dt-bindings: usb: Add analogix anx7411 PD binding

[Xin Ji <xji@xxxxxxxxxxxxxxxx>]

On Tue, Jul 12, 2022 at 11:38:47AM +0200, Krzysztof Kozlowski wrote:
> On 12/07/2022 11:05, Xin Ji wrote:
> > Add analogix PD chip anx7411 device binding
> > 
> > Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
> > Signed-off-by: Xin Ji <xji@xxxxxxxxxxxxxxxx>
> > 
> > ---
> > v13 -> v14 :
> >     1. Fix Robot compile error. Fix node name not correct.
> 
> Node name is still not correct.
Hi Krzysztof, I'll add it.
Thanks,
Xin
> 
> >     2. Change HEX to lowercase.
> >     3. Use "ports" property.
> > v12 -> v13 :
> >     1. Drop the quotes for "$id" and "$schema"
> >     2. Remove "allOf" label
> >     3. Change node name from "i2c1" to "i2c"
> >     4. Change node name from "typec" to "usb-typec"
> > 
> > Signed-off-by: Xin Ji <xji@xxxxxxxxxxxxxxxx>
> > ---
> >  .../bindings/usb/analogix,anx7411.yaml        | 81 +++++++++++++++++++
> >  1 file changed, 81 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/usb/analogix,anx7411.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/usb/analogix,anx7411.yaml b/Documentation/devicetree/bindings/usb/analogix,anx7411.yaml
> > new file mode 100644
> > index 000000000000..bbd071ba338f
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/usb/analogix,anx7411.yaml
> > @@ -0,0 +1,81 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: https://nam10.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fusb%2Fanalogix%2Canx7411.yaml%23&amp;data=05%7C01%7Cxji%40analogixsemi.com%7Ccaae32a981aa4c347a8e08da63ea5518%7Cb099b0b4f26c4cf59a0fd5be9acab205%7C0%7C0%7C637932155353583707%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=BGHo5E1W33sWfdhApWzq94%2F5TrDvfQc5lVF%2FSWl2m5A%3D&amp;reserved=0
> > +$schema: https://nam10.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23&amp;data=05%7C01%7Cxji%40analogixsemi.com%7Ccaae32a981aa4c347a8e08da63ea5518%7Cb099b0b4f26c4cf59a0fd5be9acab205%7C0%7C0%7C637932155353583707%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=7wG732uVpVNVjtxm14xiXKweazjop4xRTUe4HRZVTWM%3D&amp;reserved=0
> > +
> > +title: Analogix ANX7411 Type-C controller bindings
> > +
> > +maintainers:
> > +  - Xin Ji <xji@xxxxxxxxxxxxxxxx>
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - analogix,anx7411
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  connector:
> > +    type: object
> > +    $ref: ../connector/usb-connector.yaml
> > +    description:
> > +      Properties for usb c connector.
> > +
> > +    properties:
> > +      compatible:
> > +        const: usb-c-connector
> > +
> > +      power-role: true
> > +
> > +      data-role: true
> > +
> > +      try-power-role: true
> > +
> > +    required:
> > +      - compatible
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - connector
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/interrupt-controller/irq.h>
> > +    i2c {
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +
> > +        anx7411@2c {
> 
> Use generic node name:
> https://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdevicetree-specification.readthedocs.io%2Fen%2Flatest%2Fchapter2-devicetree-basics.html%23generic-names-recommendation&amp;data=05%7C01%7Cxji%40analogixsemi.com%7Ccaae32a981aa4c347a8e08da63ea5518%7Cb099b0b4f26c4cf59a0fd5be9acab205%7C0%7C0%7C637932155353583707%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=ACf4IGwVwtO7CsvL%2BYj4bbl%2BG88o5k6PyEyxZCl2as8%3D&amp;reserved=0
> 
> > +            compatible = "analogix,anx7411";
> > +            reg = <0x2c>;
> > +            interrupts = <8 IRQ_TYPE_EDGE_FALLING>;
> > +            interrupt-parent = <&gpio0>;
> > +
> > +            typec_con: connector {
> > +                compatible = "usb-c-connector";
> > +                power-role = "dual";
> > +                data-role = "dual";
> > +                try-power-role = "source";
> > +
> > +                ports {
> > +                    #address-cells = <1>;
> > +                    #size-cells = <0>;
> > +                    port@0 {
> > +                        reg = <0>;
> > +                        typec_con_ep: endpoint {
> > +                            remote-endpoint = <&usbotg_hs_ep>;
> > +                        };
> > +                    };
> > +                };
> > +            };
> > +        };
> > +    };
> > +...
> 
> 
> Best regards,
> Krzysztof