On 12/07/2022 11:05, Xin Ji wrote: > Add analogix PD chip anx7411 device binding > > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> > Signed-off-by: Xin Ji <xji@xxxxxxxxxxxxxxxx> > > --- > v13 -> v14 : > 1. Fix Robot compile error. Fix node name not correct. Node name is still not correct. > 2. Change HEX to lowercase. > 3. Use "ports" property. > v12 -> v13 : > 1. Drop the quotes for "$id" and "$schema" > 2. Remove "allOf" label > 3. Change node name from "i2c1" to "i2c" > 4. Change node name from "typec" to "usb-typec" > > Signed-off-by: Xin Ji <xji@xxxxxxxxxxxxxxxx> > --- > .../bindings/usb/analogix,anx7411.yaml | 81 +++++++++++++++++++ > 1 file changed, 81 insertions(+) > create mode 100644 Documentation/devicetree/bindings/usb/analogix,anx7411.yaml > > diff --git a/Documentation/devicetree/bindings/usb/analogix,anx7411.yaml b/Documentation/devicetree/bindings/usb/analogix,anx7411.yaml > new file mode 100644 > index 000000000000..bbd071ba338f > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/analogix,anx7411.yaml > @@ -0,0 +1,81 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/usb/analogix,anx7411.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Analogix ANX7411 Type-C controller bindings > + > +maintainers: > + - Xin Ji <xji@xxxxxxxxxxxxxxxx> > + > +properties: > + compatible: > + enum: > + - analogix,anx7411 > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + connector: > + type: object > + $ref: ../connector/usb-connector.yaml > + description: > + Properties for usb c connector. > + > + properties: > + compatible: > + const: usb-c-connector > + > + power-role: true > + > + data-role: true > + > + try-power-role: true > + > + required: > + - compatible > + > +required: > + - compatible > + - reg > + - connector > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/irq.h> > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + anx7411@2c { Use generic node name: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > + compatible = "analogix,anx7411"; > + reg = <0x2c>; > + interrupts = <8 IRQ_TYPE_EDGE_FALLING>; > + interrupt-parent = <&gpio0>; > + > + typec_con: connector { > + compatible = "usb-c-connector"; > + power-role = "dual"; > + data-role = "dual"; > + try-power-role = "source"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + port@0 { > + reg = <0>; > + typec_con_ep: endpoint { > + remote-endpoint = <&usbotg_hs_ep>; > + }; > + }; > + }; > + }; > + }; > + }; > +... Best regards, Krzysztof
