On Mon, Jul 04, 2022 at 05:31:29PM +0800, szuni chen wrote: > Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> 於 2022年7月4日 週一 下午3:32寫道： > > > > On Mon, Jul 04, 2022 at 01:38:56PM +0800, ChiaEn Wu wrote: > > > From: ChiYuan Huang <cy_huang@xxxxxxxxxxx> > > > > > > Add chip level mt6370 tcpci driver. > > > > What does this mean? Please provide more information about the hardware > > being supported here so we know how to review this. > > Dear Greg, > > MediaTek MT6370 is a highly-integrated smart power management IC, > which includes a single cell Li-Ion/Li-Polymer switching battery charger, > a USB Type-C & Power Delivery (PD) controller, dual flash LED current sources, > a RGB LED driver, a backlight WLED driver, a display bias driver and a > general LDO for portable devices. > > This driver is used for the Type-C & Power Delivery controller in > MediaTek MT6370 IC. > > If we change the commit message to > > "Add MediaTek MT6370 tcpci driver. > MediaTek MT6370 is a multi-functional IC that includes USB Type-C. > It works with Type-C Port Controller Manager to provide USB PD and USB > Type-C functionalities." > > does this meet your requirements? What would you want to see if you were reading a changelog text for an unfamiliar hardware device? More text is always better! thanks, greg k-h
