Re: [PATCH] USB: serial: Fix read regression in 2.6.31

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am Donnerstag, 24. September 2009 23:32:39 schrieb Johan Hovold:
> > >     /* cancel any scheduled reading */
> > >     cancel_delayed_work_sync(&priv->rx_work);
> >
> > You can, if you wish to hide what's going on, poison the urb. The
> > correct sequence is:
> >
> > 1. poison the urb
> > 2. cancel_delayed_work_sync
> >
> > 3. unpoison the urb
>
> <snip>
>
> > Step 1 sets a flag.
>
> And this is what we generally want to be doing I assume, rather than
> adding an explicit state flag?

Now that you mention it, it seems like a good idea to me.

	Regards
		Oliver

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux