On Tue, May 03, 2022 at 03:15:03PM +0200, Lukas Wunner wrote:
> smsc95xx_reset() resets the PHY behind the PHY driver's back, which
> seems like a bad idea generally. Remove that portion of the function.
>
> We're about to use PHY interrupts instead of polling to detect link
> changes on SMSC LAN95xx chips. Because smsc95xx_reset() is called from
> usbnet_open(), PHY interrupt settings are lost whenever the net_device
> is brought up.
>
> There are two other callers of smsc95xx_reset(), namely smsc95xx_bind()
> and smsc95xx_reset_resume(), and both may indeed benefit from a PHY
> reset. However they already perform one through their calls to
> phy_connect_direct() and phy_init_hw().
>
> Tested-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx> # LAN9514/9512/9500
> Tested-by: Ferry Toth <fntoth@xxxxxxxxx> # LAN9514
> Signed-off-by: Lukas Wunner <lukas@xxxxxxxxx>
> Cc: Martyn Welch <martyn.welch@xxxxxxxxxxxxx>
> Cc: Gabriel Hojda <ghojda@xxxxxxxxx>
Reviewed-by: Andrew Lunn <andrew@xxxxxxx>
Andrew
