Re: iRiver P7 UNUSUAL_DEV "patch"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Greg,

Please apply.

Signed-off-by: Phil Dibowitz <phil@xxxxxxxx>

----- Forwarded message from Sergey Pinaev <dfo@xxxxxxxx> -----

Date: Thu, 17 Sep 2009 17:26:50 +0400
From: Sergey Pinaev <dfo@xxxxxxxx>
To: Phil Dibowitz <phil@xxxxxxxx>
Cc: linux-usb@xxxxxxxxxxxxxxx, usb-storage@xxxxxxxxxxxxxxxxxxxxxxxx
Subject: Re: iRiver P7 UNUSUAL_DEV "patch"

On Thu, 17 Sep 2009 15:09:35 +0200
Phil Dibowitz <phil@xxxxxxxx> wrote:

> > +UNUSUAL_DEV(  0x4102, 0x1059, 0x0000,  0xFFFF,
> 
> 0xffff isn't valid, it's BCD, so 0x9999 is the highest.
> 
> However, please don't include the whole range unless you have reason
> to believe the whole range is affected. In this case just 0000 should
> do the trick.

i dont know, what "BCD" is. based on what can i find i tought
it is something like "firmware revision". and since i think that
iRiver never will fix it i choosed minimum and maximum values =)
ok, lets try with 0000.

> Can you send an updated patch and we'll get it included?

here it is:

--- linux-2.6.30/drivers/usb/storage/unusual_devs.h.orig        2009-09-17 16:57:00 +0400
+++ linux-2.6.30/drivers/usb/storage/unusual_devs.h     2009-09-17 16:56:35 +0400
@@ -1836,6 +1836,13 @@ UNUSUAL_DEV(  0x4102, 0x1020, 0x0100,  0
                US_SC_DEVICE, US_PR_DEVICE, NULL,
                US_FL_IGNORE_RESIDUE ),
 
+/* Reported by Sergey Pinaev <dfo@xxxxxxxx> */
+UNUSUAL_DEV(  0x4102, 0x1059, 0x0000,  0x0000,
+               "iRiver",
+               "P7K",
+               US_SC_DEVICE, US_PR_DEVICE, NULL,
+               US_FL_MAX_SECTORS_64 ),
+
 /*
  * David Hц╓rdeman <david@xxxxxxxx>
  * The key makes the SCSI stack print confusing (but harmless) messages


Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux