Re: [PATCH 1/3] usb console: fix mutex lock regression

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 17 Sep 2009, Jason Wessel wrote:

> Alan Stern wrote:
> > On Wed, 16 Sep 2009, Jason Wessel wrote:
> >
> >   
> >> During the 2.6.32 development the use of serial->disc_mutex was
> >> introduced.  In usb_console_setup() the call to
> >> usb_serial_get_by_index() will obtain this mutex. The
> >> usb_console_setup() must release the mutex before it completes else
> >> later calls to the usb serial core will hang.
> >>     
> >
> > Apparently you didn't see my patch:
> >
> > 	http://marc.info/?l=linux-usb&m=125209260714221&w=2
> >
> > Did this not get into linus-next?  Greg?
> >
> >   
> 
> FYI, I'll continue working on the tty baud usb serial problem.   Are
> there other patches I need Alan?  

The eight-patch series plus the one additional console patch are all 
that I wrote.

> When I tried your patch on the end of the of the Greg KH tree, it
> crashes the kernel, which is why I am asking before I try anything further.

It didn't crash my kernel when I tried it.  :-)  Did you figure out 
what was wrong?

> I have a forth coming patch based on what Alan Cox sent me about the
> init_termios structure.  This patch very cleanly solves the problem of
> the initial console baud, but the new init_termios wasn't documented
> anywhere except the source itself.  In a nut shell the entire API is
> there, but th usb serial console code was not using it until now.  :-)

No kidding --  that's mostly what my patches were aimed at: using the 
new API correctly.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux