On Wed, Feb 16, 2022 at 09:57:04AM +0000, Linyu Yuan (QUIC) wrote:
> > From: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxx>
> > Sent: Wednesday, February 16, 2022 5:53 PM
> > To: Linyu Yuan (QUIC) <quic_linyyuan@xxxxxxxxxxx>; Mathias Nyman
> > <mathias.nyman@xxxxxxxxx>; Greg Kroah-Hartman
> > <gregkh@xxxxxxxxxxxxxxxxxxx>
> > Cc: linux-usb@xxxxxxxxxxxxxxx; Jack Pham (QUIC) <quic_jackp@xxxxxxxxxxx>
> > Subject: Re: [PATCH 1/5] usb: host: xhci: use ffs() in xhci_mem_init()
> >
> > On 2/16/22 12:47 PM, Linyu Yuan (QUIC) wrote:
> >
> > > that's correct, from my view, one line is good,
> > >
> > > What's your suggestion ? two lines ?
> >
> > Yes, and it is not just my suggestion -- it's the kernel coding style.
> I think in linux, there are many code like this,
>
> arch/m68k/sun3x/dvma.c: if((pmd = pmd_alloc(&init_mm, pud, vaddr)) == NULL) {
> ...
That file pre-dates the use of the kernel coding style. Please look at
modern code (i.e. written in the last 15 years.)
thanks,
greg k-h
