On 2/16/22 12:57 PM, Linyu Yuan (QUIC) wrote: [...] >>> that's correct, from my view, one line is good, >>> >>> What's your suggestion ? two lines ? >> >> Yes, and it is not just my suggestion -- it's the kernel coding style. > I think in linux, there are many code like this, > > arch/m68k/sun3x/dvma.c: if((pmd = pmd_alloc(&init_mm, pud, vaddr)) == NULL) { > ... > > Two lines here is not good. Why?! 8-) >> [...] MBR, Sergey