On 2022-02-02 12:49:16 [-0800], Bart Van Assche wrote: > On 2/1/22 13:09, Sebastian Andrzej Siewior wrote: > > -void scsi_done(struct scsi_cmnd *cmd) > > +static bool scsi_done_need_blk_compl(struct scsi_cmnd *cmd) > > I'm not happy about the name of this function. The word "need" in the > function name suggests that this function does not modify any state. > However, the body of the function shows that it may complete a SCSI command. > How about renaming the existing scsi_done() function into > scsi_done_internal() or so and adding a "bool complete_directly" argument to > that function? Let me see what I can do. > BTW, I only received patch 1/2 but not patch 2/2. Please Cc the linux-scsi > mailing list for the entire patch series when reposting the patch series. I did and based on lore's archive it made it to the list: https://lore.kernel.org/linux-scsi/20220201210954.570896-1-sebastian@xxxxxxxxxxxxx/ > Thanks, > > Bart. Sebastian
