On 2/1/22 13:09, Sebastian Andrzej Siewior wrote:
-void scsi_done(struct scsi_cmnd *cmd) +static bool scsi_done_need_blk_compl(struct scsi_cmnd *cmd)
I'm not happy about the name of this function. The word "need" in the function name suggests that this function does not modify any state. However, the body of the function shows that it may complete a SCSI command. How about renaming the existing scsi_done() function into scsi_done_internal() or so and adding a "bool complete_directly" argument to that function?
BTW, I only received patch 1/2 but not patch 2/2. Please Cc the linux-scsi mailing list for the entire patch series when reposting the patch series.
Thanks, Bart.
