Re: [PATCH 1/5] USB OTG: add support for ulpi connected external transceivers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Sep 12, 2009 at 05:24:59PM +0400, Sergei Shtylyov wrote:
> >>+#define USB_OTG_PULLUP_ID        (1 << 0)
> >>+#define USB_OTG_PULLDOWN_DP        (1 << 1)
> >>+#define USB_OTG_PULLDOWN_DM        (1 << 2)
> >>+#define USB_OTG_EXT_VBUS_INDICATOR    (1 << 3)
> >>+#define USB_OTG_DRV_VBUS        (1 << 4)
> >>+#define USB_OTG_DRV_VBUS_EXT        (1 << 5)
> >This adds support for OTG transceivers directly connected to the ULPI
> >
> >  Why not just use the standard ULPI control register bit
> >defintitions instead of these?
> 
>   Ah, some of them do correspond...

Just some tranlation, yes.

>   I still don't get why USB_OTG_DRV_VBUS exists, as well as the
> pulldown flags -- these pulldowns are a part of USB/OTG protocol, so
> any fixed setting hardly makes sense...

Hmm. I thought this lets you decide whether you use the internal
pulls or use external ones. How would the OTG core alter the behaviour
then? Which code would be missing to support it the way the OTG stack
works?

Thanks,
Daniel
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux