Re: [PATCH 1/5] USB OTG: add support for ulpi connected external transceivers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hello, I wrote:

interface. In particular, the following details are added

- a struct for low level io functions (read/write)
- a priv field to be used as 'viewport' by low level access functions
- an (*init) and (*shutdown) callbacks, along with static inline helpers
- a (*set_vbus) callback to switch the port power on and off
- a flags field for per-transceiver settings
- some defines for the flags bitmask to configure platform specific
  details

Signed-off-by: Daniel Mack <daniel@xxxxxxxx>
Cc: Greg Kroah-Hartman <gregkh@xxxxxxx>
Cc: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx>
Cc: linux-usb@xxxxxxxxxxxxxxx
---
include/linux/usb/otg.h | 68 ++++++++++++++++++++++++++++++++++++++++++++++-
 1 files changed, 67 insertions(+), 1 deletions(-)

diff --git a/include/linux/usb/otg.h b/include/linux/usb/otg.h
index 2443c0e..52bb917 100644
--- a/include/linux/usb/otg.h
+++ b/include/linux/usb/otg.h
@@ -33,6 +33,23 @@ enum usb_otg_state {
     OTG_STATE_A_VBUS_ERR,
 };
+#define USB_OTG_PULLUP_ID (1 << 0)
+#define USB_OTG_PULLDOWN_DP        (1 << 1)
+#define USB_OTG_PULLDOWN_DM        (1 << 2)
+#define USB_OTG_EXT_VBUS_INDICATOR    (1 << 3)
+#define USB_OTG_DRV_VBUS        (1 << 4)
+#define USB_OTG_DRV_VBUS_EXT        (1 << 5)
This adds support for OTG transceivers directly connected to the ULPI

Why not just use the standard ULPI control register bit defintitions instead of these?

  Ah, some of them do correspond...
I still don't get why USB_OTG_DRV_VBUS exists, as well as the pulldown flags -- these pulldowns are a part of USB/OTG protocol, so any fixed setting hardly makes sense...

WBR, Sergei


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux