On 05.01.22 18:30, Andrew Lunn wrote: > On Wed, Jan 05, 2022 at 11:14:25PM +0800, Aaron Ma wrote: >> When plugin multiple r8152 ethernet dongles to Lenovo Docks >> or USB hub, MAC passthrough address from BIOS should be >> checked if it had been used to avoid using on other dongles. >> >> Currently builtin r8152 on Dock still can't be identified. >> First detected r8152 will use the MAC passthrough address. > I do have to wonder why you are doing this in the kernel, and not > using a udev rule? This seems to be policy, and policy does not belong > in the kernel. Debatable. An ethernet NIC has to have a MAC. The kernel must provide one. That we should always take the one found in the device's ROM rather than the host's ROM is already a policy decision. In fact we make up a MAC for devices that do not have one. Regards Oliver
