Am Wed, 5 Jan 2022 18:30:08 +0100 schrieb Andrew Lunn <andrew@xxxxxxx>: > On Wed, Jan 05, 2022 at 11:14:25PM +0800, Aaron Ma wrote: > > When plugin multiple r8152 ethernet dongles to Lenovo Docks > > or USB hub, MAC passthrough address from BIOS should be > > checked if it had been used to avoid using on other dongles. > > > > Currently builtin r8152 on Dock still can't be identified. > > First detected r8152 will use the MAC passthrough address. > > I do have to wonder why you are doing this in the kernel, and not > using a udev rule? This seems to be policy, and policy does not belong > in the kernel. Yes, the whole pass-thru story should not be a kernel feature in the first place, i could not agree more, udev would be the way better place! But it is part of the driver and Aaron did not introduce it but just extend it. Henning > Andrew