Re: [PATCH 05/11] [Storage] Uses msf prefix throughout the file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 4 Sep 2009, [utf-8] MichaÅ? Nazarewicz wrote:

> On Thu, 03 Sep 2009 22:51:04 +0200, Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote:
> 
> > On Mon, 31 Aug 2009, [iso-8859-2] Micha³ Nazarewicz wrote:
> >
> >> All the fsg prefixes have been replaced with msf.  Moreover, functions
> >> which lacked prefix gained msf prefix.  This change has been made as
> >> to prevent any possible name collisions when Mass Storage Function
> >> is used with other composite functions.
> >
> > Why not just add fsg to functions that don't have a prefix?
> 
> I think it would be somehow awkward if functions in Mass Storage
> Function would be prefixed with fsg.  That's why I decided to use
> prefixes I have described in previous mails (stor, fsg and msf).

IMO, having three different prefixes is more awkward than having a 
single slightly inappropriate prefix.  If you think it might help, put 
a comment near the start of the file explaining that "fsg" is short for 
"File-backed Storage Gadget" and it is used because the function code 
was originally derived from the standalone gadget code.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux