On Fri, 4 Sep 2009, [utf-8] MichaÅ? Nazarewicz wrote: > On Thu, 03 Sep 2009 22:44:47 +0200, Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote: > > > On Mon, 31 Aug 2009, [iso-8859-2] Micha³ Nazarewicz wrote: > > > >> Also, names of various functions, structures and variables > >> have been changed. This is to prevent potential name > >> collision when the common file will be used with other code. > > > > Personally, I dislike seeing Changelog messages that are continuations > > of the Subject line. They can easily get separated, making the context > > difficult or impossible to figure out. > > I've just copied and pasted what format-patch gave me. Will take this > opinion in future submissions though. Maybe I should complain to the git maintainers... > >> @@ -170,10 +172,10 @@ > >> * REGISTERED atomic bitflag; the driver will only be deregistered once. > >> * The second problem is resolved by having fsg_unbind() check > >> * fsg->state; it won't try to stop the thread if the state is already > >> - * FSG_STATE_TERMINATED. > >> + * STOR_STATE_TERMINATED. > > > > Did you really have to change all these things throughout the entire > > file? > > Well. I though that using FSG prefix in storage_common as well as > mass_storage will be awkward. That's why I decided to use "stor" > for storage_common (ie. thinks common for both FSG and MSF that is > /storage/ gadget/function), "fsg" for file_storage and "msf" for > f_mass_storage. Using "stor" is awkward too. It doesn't distinguish between gadget-side and host-side; there are functions in the usb-storage driver that use "usb_stor_" as a prefix. IMO you might as well use "fsg" for everything, even though it isn't entirely appropriate for a file-backed storage _function_. Things like this happen for historical reasons all the time. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
