Re: [PATCH 06/11] [Storage] Parts of the struct msf moved to struct msf_common

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 31 Aug 2009, [iso-8859-2] Micha³ Nazarewicz wrote:
In the final version, many msf structures will refer to a single
msf_common structure and so it is required to move common data
to another object which can be shared.

On Thu, 03 Sep 2009 22:52:53 +0200, Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote:
I don't understand this.  Are you concerned about situations where a
single gadget might contain several independent Mass-Storage
interfaces?  If they are independent, how can they share common data?

I'm concerned about using MSF in several USB configurations.  Those
MSFs will need to share various data and that's what msf_common is for.
At to this point, I moved LUNs and some buffers to the msf_common
structure.  The former makes it possible to use MSF in several
configurations (while I was testing Android's code I was unable to use
their function in two configurations because each instance tried to
create its own LUN devices and bind files in sysfs) and the later is
just a way to optimize memory usage a bit (ie. one buffer for all
instances instead of one buffer per instance).

What I haven't solved yet, but am working on, is problem with kernel
thread.  At the moment each binding of a MSF to USB configuration
creates a kernel thread (so a gadget with a single MSF in two
configurations create two kernel threads).  There are some other
things that need to be done with existing code (at the moment I'm
hunting a bug that somehow appeared) and I will deal with the
thread issue later on (I think I have some basic idea how to do
this).

--
Best regards,                                            _     _
 .o. | Liege of Serenely Enlightened Majesty of        o' \,=./ `o
 ..o | Computer Science,  Michał "mina86" Nazarewicz      (o o)
 ooo +-<m.nazarewicz@xxxxxxxxxxx>-<mina86@xxxxxxxxxx>-ooO--(_)--Ooo--

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux