Hi Conor, On Mon, Nov 8, 2021 at 4:07 PM <conor.dooley@xxxxxxxxxxxxx> wrote: > From: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > > Add device tree bindings for the usb controller on > the Microchip PolarFire SoC. > > Signed-off-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> Thanks for your patch! > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/microchip,mpfs-usb-host.yaml > @@ -0,0 +1,70 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/usb/microchip,mpfs-usb-host.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Microchip MPFS USB Controller Device Tree Bindings > + > +maintainers: > + - Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > + > +description: | > + This USB controller is found on the Microchip PolarFire SoC. > + > +properties: > + compatible: > + enum: > + - microchip,mpfs-usb-host "microchip-mpfs-usb", given the dr_mode property below indicates this controller is not limited to host mode? > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + interrupt-names: > + minItems: 2 > + items: > + - const: dma > + - const: mc > + > + clocks: > + maxItems: 1 > + > + dr_mode: > + enum: > + - host > + - otg > + - peripheral > + > +required: > + - compatible > + - reg > + - interrupts > + - interrupt-names > + - clocks > + - dr_mode > + > +additionalProperties: false > + > +examples: > + - | > + #include "dt-bindings/clock/microchip,mpfs-clock.h" > + #include "dt-bindings/interrupt-controller/microchip,mpfs-plic.h" > + soc { > + #address-cells = <2>; > + #size-cells = <2>; Please drop these two... > + usb: usb@20201000 { > + compatible = "microchip,mpfs-usb-host"; > + reg = <0x0 0x20201000 0x0 0x1000>; ... and the zeros here. > + clocks = <&clkcfg CLK_USB>; > + interrupt-parent = <&plic>; > + interrupts = <PLIC_INT_USB_DMA PLIC_INT_USB_MC>; Please group by angular brackets: <PLIC_INT_USB_DMA>, <PLIC_INT_USB_MC>. > + interrupt-names = "dma","mc"; > + dr_mode = "host"; > + status = "disabled"; Please drop this. > + }; > + }; > + > +... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
