Re: [PATCH -next] usb: core: Remove unused including <linux/version.h>

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Zou,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on next-20210922]

url:    https://github.com/0day-ci/linux/commits/Zou-Wei/usb-core-Remove-unused-including-linux-version-h/20210929-195024
base:    e90f9946ba2858ebca541c15378f5290bf2184fb
config: riscv-randconfig-r042-20210929 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project dc6e8dfdfe7efecfda318d43a06fae18b40eb498)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install riscv cross compiling tool for clang build
        # apt-get install binutils-riscv64-linux-gnu
        # https://github.com/0day-ci/linux/commit/076ec43ee612b7980ff4b09b55e25d7db99eef5d
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Zou-Wei/usb-core-Remove-unused-including-linux-version-h/20210929-195024
        git checkout 076ec43ee612b7980ff4b09b55e25d7db99eef5d
        # save the attached .config to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash drivers/usb/core/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

>> drivers/usb/core/hcd.c:129:2: error: use of undeclared identifier 'LINUX_VERSION_PATCHLEVEL'
           KERNEL_VER, KERNEL_REL, /*  __le16 bcdDevice */
           ^
   drivers/usb/core/hcd.c:114:28: note: expanded from macro 'KERNEL_VER'
   #define KERNEL_VER      bin2bcd(LINUX_VERSION_PATCHLEVEL)
                                   ^
>> drivers/usb/core/hcd.c:129:2: error: use of undeclared identifier 'LINUX_VERSION_PATCHLEVEL'
   drivers/usb/core/hcd.c:114:28: note: expanded from macro 'KERNEL_VER'
   #define KERNEL_VER      bin2bcd(LINUX_VERSION_PATCHLEVEL)
                                   ^
>> drivers/usb/core/hcd.c:129:2: error: use of undeclared identifier 'LINUX_VERSION_PATCHLEVEL'
   drivers/usb/core/hcd.c:114:28: note: expanded from macro 'KERNEL_VER'
   #define KERNEL_VER      bin2bcd(LINUX_VERSION_PATCHLEVEL)
                                   ^
>> drivers/usb/core/hcd.c:129:2: error: use of undeclared identifier 'LINUX_VERSION_PATCHLEVEL'
   drivers/usb/core/hcd.c:114:28: note: expanded from macro 'KERNEL_VER'
   #define KERNEL_VER      bin2bcd(LINUX_VERSION_PATCHLEVEL)
                                   ^
>> drivers/usb/core/hcd.c:129:14: error: use of undeclared identifier 'LINUX_VERSION_MAJOR'
           KERNEL_VER, KERNEL_REL, /*  __le16 bcdDevice */
                       ^
   drivers/usb/core/hcd.c:113:28: note: expanded from macro 'KERNEL_REL'
   #define KERNEL_REL      bin2bcd(LINUX_VERSION_MAJOR)
                                   ^
>> drivers/usb/core/hcd.c:129:14: error: use of undeclared identifier 'LINUX_VERSION_MAJOR'
   drivers/usb/core/hcd.c:113:28: note: expanded from macro 'KERNEL_REL'
   #define KERNEL_REL      bin2bcd(LINUX_VERSION_MAJOR)
                                   ^
>> drivers/usb/core/hcd.c:129:14: error: use of undeclared identifier 'LINUX_VERSION_MAJOR'
   drivers/usb/core/hcd.c:113:28: note: expanded from macro 'KERNEL_REL'
   #define KERNEL_REL      bin2bcd(LINUX_VERSION_MAJOR)
                                   ^
>> drivers/usb/core/hcd.c:129:14: error: use of undeclared identifier 'LINUX_VERSION_MAJOR'
   drivers/usb/core/hcd.c:113:28: note: expanded from macro 'KERNEL_REL'
   #define KERNEL_REL      bin2bcd(LINUX_VERSION_MAJOR)
                                   ^
   drivers/usb/core/hcd.c:150:2: error: use of undeclared identifier 'LINUX_VERSION_PATCHLEVEL'
           KERNEL_VER, KERNEL_REL, /*  __le16 bcdDevice */
           ^
   drivers/usb/core/hcd.c:114:28: note: expanded from macro 'KERNEL_VER'
   #define KERNEL_VER      bin2bcd(LINUX_VERSION_PATCHLEVEL)
                                   ^
   drivers/usb/core/hcd.c:150:2: error: use of undeclared identifier 'LINUX_VERSION_PATCHLEVEL'
   drivers/usb/core/hcd.c:114:28: note: expanded from macro 'KERNEL_VER'
   #define KERNEL_VER      bin2bcd(LINUX_VERSION_PATCHLEVEL)
                                   ^
   drivers/usb/core/hcd.c:150:2: error: use of undeclared identifier 'LINUX_VERSION_PATCHLEVEL'
   drivers/usb/core/hcd.c:114:28: note: expanded from macro 'KERNEL_VER'
   #define KERNEL_VER      bin2bcd(LINUX_VERSION_PATCHLEVEL)
                                   ^
   drivers/usb/core/hcd.c:150:2: error: use of undeclared identifier 'LINUX_VERSION_PATCHLEVEL'
   drivers/usb/core/hcd.c:114:28: note: expanded from macro 'KERNEL_VER'
   #define KERNEL_VER      bin2bcd(LINUX_VERSION_PATCHLEVEL)
                                   ^
   drivers/usb/core/hcd.c:150:14: error: use of undeclared identifier 'LINUX_VERSION_MAJOR'
           KERNEL_VER, KERNEL_REL, /*  __le16 bcdDevice */
                       ^
   drivers/usb/core/hcd.c:113:28: note: expanded from macro 'KERNEL_REL'
   #define KERNEL_REL      bin2bcd(LINUX_VERSION_MAJOR)
                                   ^
   drivers/usb/core/hcd.c:150:14: error: use of undeclared identifier 'LINUX_VERSION_MAJOR'
   drivers/usb/core/hcd.c:113:28: note: expanded from macro 'KERNEL_REL'
   #define KERNEL_REL      bin2bcd(LINUX_VERSION_MAJOR)
                                   ^
   drivers/usb/core/hcd.c:150:14: error: use of undeclared identifier 'LINUX_VERSION_MAJOR'
   drivers/usb/core/hcd.c:113:28: note: expanded from macro 'KERNEL_REL'
   #define KERNEL_REL      bin2bcd(LINUX_VERSION_MAJOR)
                                   ^
   drivers/usb/core/hcd.c:150:14: error: use of undeclared identifier 'LINUX_VERSION_MAJOR'
   drivers/usb/core/hcd.c:113:28: note: expanded from macro 'KERNEL_REL'
   #define KERNEL_REL      bin2bcd(LINUX_VERSION_MAJOR)
                                   ^
   drivers/usb/core/hcd.c:171:2: error: use of undeclared identifier 'LINUX_VERSION_PATCHLEVEL'
           KERNEL_VER, KERNEL_REL, /*  __le16 bcdDevice */
           ^
   drivers/usb/core/hcd.c:114:28: note: expanded from macro 'KERNEL_VER'
   #define KERNEL_VER      bin2bcd(LINUX_VERSION_PATCHLEVEL)
                                   ^
   drivers/usb/core/hcd.c:171:2: error: use of undeclared identifier 'LINUX_VERSION_PATCHLEVEL'
   drivers/usb/core/hcd.c:114:28: note: expanded from macro 'KERNEL_VER'
   #define KERNEL_VER      bin2bcd(LINUX_VERSION_PATCHLEVEL)
                                   ^
   drivers/usb/core/hcd.c:171:2: error: use of undeclared identifier 'LINUX_VERSION_PATCHLEVEL'
   drivers/usb/core/hcd.c:114:28: note: expanded from macro 'KERNEL_VER'
   #define KERNEL_VER      bin2bcd(LINUX_VERSION_PATCHLEVEL)
                                   ^
   fatal error: too many errors emitted, stopping now [-ferror-limit=]
   20 errors generated.


vim +/LINUX_VERSION_PATCHLEVEL +129 drivers/usb/core/hcd.c

^1da177e4c3f41 Linus Torvalds 2005-04-16  115  
9508e3b7a70c11 Mathias Nyman  2015-12-10  116  /* usb 3.1 root hub device descriptor */
9508e3b7a70c11 Mathias Nyman  2015-12-10  117  static const u8 usb31_rh_dev_descriptor[18] = {
9508e3b7a70c11 Mathias Nyman  2015-12-10  118  	0x12,       /*  __u8  bLength; */
9508e3b7a70c11 Mathias Nyman  2015-12-10  119  	USB_DT_DEVICE, /* __u8 bDescriptorType; Device */
9508e3b7a70c11 Mathias Nyman  2015-12-10  120  	0x10, 0x03, /*  __le16 bcdUSB; v3.1 */
9508e3b7a70c11 Mathias Nyman  2015-12-10  121  
9508e3b7a70c11 Mathias Nyman  2015-12-10  122  	0x09,	    /*  __u8  bDeviceClass; HUB_CLASSCODE */
9508e3b7a70c11 Mathias Nyman  2015-12-10  123  	0x00,	    /*  __u8  bDeviceSubClass; */
9508e3b7a70c11 Mathias Nyman  2015-12-10  124  	0x03,       /*  __u8  bDeviceProtocol; USB 3 hub */
9508e3b7a70c11 Mathias Nyman  2015-12-10  125  	0x09,       /*  __u8  bMaxPacketSize0; 2^9 = 512 Bytes */
9508e3b7a70c11 Mathias Nyman  2015-12-10  126  
9508e3b7a70c11 Mathias Nyman  2015-12-10  127  	0x6b, 0x1d, /*  __le16 idVendor; Linux Foundation 0x1d6b */
9508e3b7a70c11 Mathias Nyman  2015-12-10  128  	0x03, 0x00, /*  __le16 idProduct; device 0x0003 */
9508e3b7a70c11 Mathias Nyman  2015-12-10 @129  	KERNEL_VER, KERNEL_REL, /*  __le16 bcdDevice */
9508e3b7a70c11 Mathias Nyman  2015-12-10  130  
9508e3b7a70c11 Mathias Nyman  2015-12-10  131  	0x03,       /*  __u8  iManufacturer; */
9508e3b7a70c11 Mathias Nyman  2015-12-10  132  	0x02,       /*  __u8  iProduct; */
9508e3b7a70c11 Mathias Nyman  2015-12-10  133  	0x01,       /*  __u8  iSerialNumber; */
9508e3b7a70c11 Mathias Nyman  2015-12-10  134  	0x01        /*  __u8  bNumConfigurations; */
9508e3b7a70c11 Mathias Nyman  2015-12-10  135  };
9508e3b7a70c11 Mathias Nyman  2015-12-10  136  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux