On Sun, Sep 19, 2021 at 09:57:28PM +0200, Florian Faber wrote: > In gs_rx_push, tty can be null. tty_throttled accesses tty->flags without further testing, which would lead to a null pointer dereference. Please wrap your changelog text to 72 columns. > > Signed-off-by: Florian Faber <faber@xxxxxxxxxxx> > --- > drivers/usb/gadget/function/u_serial.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/gadget/function/u_serial.c b/drivers/usb/gadget/function/u_serial.c > index 6f68cbeeee7c..00512e7c7261 100644 > --- a/drivers/usb/gadget/function/u_serial.c > +++ b/drivers/usb/gadget/function/u_serial.c > @@ -436,7 +436,7 @@ static void gs_rx_push(struct work_struct *work) > * We may leave non-empty queue only when there is a tty, and > * either it is throttled or there is no more room in flip buffer. > */ > - if (!list_empty(queue) && !tty_throttled(tty)) > + if (tty && !list_empty(queue) && !tty_throttled(tty)) Have you ever been able to trigger this with a NULL tty? thanks, greg k-h
