Hi Ulrich, On Sun, Aug 29, 2021 at 01:02:54PM +0200, Ulrich Huber wrote: > > On 28.08.21 11:48, Heikki Krogerus wrote: > > On Thu, Aug 26, 2021 at 09:50:58PM +0200, Ulrich Huber wrote: > > > I just got around to test your patches. They seem to solve the issue > > > completely! Whatever I tried, the behavior of the port stayed consistent and > > > no error messages appeared in the log. > > > > > > I'll continue using the patch for now and will notify you, should any issue > > > appear. > > Great! If there are no problems, I'll send them to Greg after the next > > -rc1. > > It seems I just found one such problem. After waking from hibernation I get > the following entries in the kernel log: > > Aug 29 11:55:31 lenovo-ulrich kernel: ucsi_acpi USBC000:00: > GET_CONNECTOR_STATUS failed (-5) > Aug 29 11:55:31 lenovo-ulrich kernel: ucsi_acpi USBC000:00: > GET_CONNECTOR_STATUS failed (-5) > Aug 29 11:55:31 lenovo-ulrich kernel: usb 3-6: reset high-speed USB device > number 3 using xhci_hcd > Aug 29 11:55:31 lenovo-ulrich kernel: ish-hid > {33AECD58-B679-4E54-9BD9-A04D34F0C226}: [hid-ish]: enum_devices_do> > Aug 29 11:55:31 lenovo-ulrich kernel: usb 3-10: reset full-speed USB device > number 4 using xhci_hcd > Aug 29 11:55:31 lenovo-ulrich kernel: usb 3-5: reset full-speed USB device > number 2 using xhci_hcd > > It is obviously related with the system resetting the hardware after waking > up. Most likely the driver tries to communicate with the device while it is > in a state where it is not able to respond. I do not get this after each > hibernation, so far it is the first time I have seen this. I'll try to find > a way to reproduce this. Any updates? Would it make sense to go ahead with my series now anyway at this point since it seems to fix the other problems? thanks, -- heikki