Re: ucsi_acpi GET_CONNECTOR_STATUS failed (-5)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Aug 25, 2021 at 08:37:14PM +0200, Ulrich Huber wrote:
> Hi,
> 
> I just managed to get some more details. The bug definitely originates from
> `ucsi_handle_connector_change`. Within this function it is the second call
> to ucsi_send_command with UCSI_GET_CONNECTOR_STATUS that fails (Step 4).
> 
> `ucsi_send_command` calls `ucsi_exec_command` internally, which does the
> synchronous write and following read. Within `ucsi_exec_command` the check
> on line 134 fails:
> 
> if (cci & UCSI_CCI_COMMAND_COMPLETE)
> 
> Hope this is of some help.

Thanks for debugging this.

Yeah, I think that the second GET_CONNECTOR_STATUS immediately after
the first one is confusing the firmware on some boards.

I'll send you a patch series I've been working on that tries to
improve the situation. I better include the list as well (sending it
as RFC).

thanks,

-- 
heikki



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux