Re: [PATCH] Add new VID/PID to support Fibocom FG150 5G module

[Lars Melin <larsm17@xxxxxxxxx>]

On 8/7/2021 22:11, Zhengjun Zhang wrote:
> Fibocom FG150 is a 5G module based on Qualcomm SDX55 platform,
> support Sub-6G band.

> +/* Fibocom products */
> +#define FIBOCOM_VENDOR_ID			0x2cb7
> +#define FIBOCOM_PRODUCT_FG150			0x010b
>   
>   /* Device flags */
>   
> @@ -2077,6 +2080,8 @@ static const struct usb_device_id option_ids[] = {
>   	{ USB_DEVICE_INTERFACE_CLASS(0x305a, 0x1404, 0xff) },			/* GosunCn GM500 RNDIS */
>   	{ USB_DEVICE_INTERFACE_CLASS(0x305a, 0x1405, 0xff) },			/* GosunCn GM500 MBIM */
>   	{ USB_DEVICE_INTERFACE_CLASS(0x305a, 0x1406, 0xff) },			/* GosunCn GM500 ECM/NCM */
> +	{ USB_DEVICE_AND_INTERFACE_INFO(FIBOCOM_VENDOR_ID, FIBOCOM_PRODUCT_FG150, 0xff, 0xff, 0x30) },
> +	{ USB_DEVICE_AND_INTERFACE_INFO(FIBOCOM_VENDOR_ID, FIBOCOM_PRODUCT_FG150, 0xff, 0, 0) },
>   	{ } /* Terminating entry */
>   };
>   MODULE_DEVICE_TABLE(usb, option_ids); >

Please don't do the defines for Fibocom VID and PID, just add them by 
their numerical value after 2cb7:0105 in the
MODULE_DEVICE_TABLE.

thanks
Lars