Re: [PATCH] drivers/usb/dwc3: Set PHY ready after soft reset done

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Yuan Fang <fangyuanseu@xxxxxxxxx> writes:

> It's more safe to set PHY ready after soft reset done
>
> Let's consider a test case like this:
> I have a usb PHY which don't need SW initial before access
> it, But i have a wrong PHY clock default setting in PHY
> register which means PHY is not ready in fact.
> in dwc3_core_init, dwc3_core_get_phy will return 0 despite
> usb get PHYs with return -ENODEV, and set phys_ready=true

your PHY driver shouldn't return -ENODEV here. Why are you returning
-ENODEV? The PHY isn't ready but it _does_ exist.

-- 
balbi

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux