> r = ch341_control_out(...); > if (r < 0) > goto timeout; > return; > timeout: > printk(KERN_WARNING...); > } > > > > ... so I thought that was OK? I'm happy to change to a different idiom > tho'... if (x) goto y return y: is pretty weird. For the other case you could still use if (!x) return y: Alan -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html