> + if (r < 0) > + goto timeout; > + return; > +timeout: > + printk(KERN_ALERT "%s: USB control request timed out in %s()!\n", > + __FILE__, __func__); > + return; You can push the goto for error paths thing too far. if r < 0) printk(KERN_...) } [and should be KERN_ERR / KERN_WARNING - probably warning ? - ALERT is for major catastrophic events, but this will leave break messed up and may well recover] -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
