On Fri, May 21, 2021 at 10:38:23AM -0400, Alan Stern wrote: > On Fri, May 21, 2021 at 10:03:26AM +0200, Johan Hovold wrote: > > On Thu, May 20, 2021 at 04:20:56PM -0400, Alan Stern wrote: > > > > + if (usb_pipeout(urb->pipe) != is_out) > > > + dev_WARN(&dev->dev, "BOGUS control dir, pipe %x doesn't match bRequestType %x\n", > > > + urb->pipe, setup->bRequestType); > > > While I agree with intention here, I'm worried that this will start > > flooding the logs of users. > > > > So first, this should probably be rate limited. > > So change it to dev_WARN_ONCE()? You and Greg think that will be good > enough? I think so, yes. In the unlikely event that there are more than one driver in use that gets this wrong in a system it'll only take a little longer to root them all out. Johan
