On Fri, May 21, 2021 at 10:03:26AM +0200, Johan Hovold wrote: > On Thu, May 20, 2021 at 04:20:56PM -0400, Alan Stern wrote: > > + if (usb_pipeout(urb->pipe) != is_out) > > + dev_WARN(&dev->dev, "BOGUS control dir, pipe %x doesn't match bRequestType %x\n", > > + urb->pipe, setup->bRequestType); > While I agree with intention here, I'm worried that this will start > flooding the logs of users. > > So first, this should probably be rate limited. So change it to dev_WARN_ONCE()? You and Greg think that will be good enough? > Second, did you try to estimate how many call sites that get this wrong? No. I couldn't think of a good way to search for them. My guess is that the number isn't terribly big, but I don't know. > I always felt a bit pedantic when pointing out that the pipe direction > should match the request type to driver author's during review when (in > almost all cases?) this hasn't really mattered. I fear we may have > accumulated a fairly large number of these mismatches over the years but > I haven't verified that. Alan Stern
