Re: [PATCH] USB: gadget: lpc32xx_udc: remove debugfs dentry variable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 19, 2021 at 03:05:18PM +0300, Felipe Balbi wrote:
> Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> writes:
> 
> > There is no need to store the dentry for a fixed filename that we have
> > the string for.  So just have debugfs look it up when we need it to
> > remove the file, no need to store it anywhere locally.
> >
> > Note, this driver is broken in that debugfs will not work for more than
> > one instance of the device it supports.  But given that this patch does
> > not change that, and no one has ever seemed to notice, it must not be an
> > issue...
> >
> > Cc: Felipe Balbi <balbi@xxxxxxxxxx>
> > Cc: Vladimir Zapolskiy <vz@xxxxxxxxx>
> > Cc: linux-usb@xxxxxxxxxxxxxxx
> > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> 
> Acked-by: Felipe Balbi <balbi@xxxxxxxxxx>

Great, thanks for the review.

greg k-h



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux