On Wed, May 19, 2021 at 02:09:17PM +0300, Vladimir Zapolskiy wrote: > On 5/18/21 7:20 PM, Greg Kroah-Hartman wrote: > > There is no need to store the dentry for a fixed filename that we have > > the string for. So just have debugfs look it up when we need it to > > remove the file, no need to store it anywhere locally. > > > > Note, this driver is broken in that debugfs will not work for more than > > one instance of the device it supports. But given that this patch does > > not change that, and no one has ever seemed to notice, it must not be an > > issue... > > Yep, there is only one SoC with this device, and it has only one instance > of this UDC. Bad excuse, I know it. Not a big deal :) > > Cc: Felipe Balbi <balbi@xxxxxxxxxx> > > Cc: Vladimir Zapolskiy <vz@xxxxxxxxx> > > Cc: linux-usb@xxxxxxxxxxxxxxx > > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > > Acked-by: Vladimir Zapolskiy <vz@xxxxxxxxx> Thanks for the review! greg k-h
