On Fri, Apr 30, 2021 at 11:43:49AM +0800, Peter Chen wrote: > On 21-04-29 10:49:14, Pawel Laszczak wrote: > > From: Pawel Laszczak <pawell@xxxxxxxxxxx> > > > > Patch removes the warning "variable dereferenced before > > check 'pdev->dcbaa'" from cdnsp_mem_cleanup. > > You may describe the real problem you fix, but not the warning > message from some auto build system. > I really feel people have become too lost in the weeds of what matters and what does not. For internships, people want picky feedback in case they're forced to deal with the ultra drill sargent maintainers. But really the important thing in a commit message is if you can understand the problem and the fix. In this case everyone who is capable of understanding the patch can understand the commit message. Also if you're going to criticize someone's commit message then just write it the way you want so they can copy and paste. I had someone yesterday say that my commit message where I deleted a NULL check and related dead code was not clear enough that the behavior was "intentional" and I took that to mean that they wanted me to say that deleting the dead code did not change runtime behavior. I'm still not sure that's what they wanted me to add... The point is no one can read your mind, if you want a commit message to say something specific then just say it instead of hinting around the bush and we have to send a v2 and v3 commit message. regards, dan carpenter
