Re: [PATCH] usb: cdnsp: Useless condition has been removed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 21-04-29 10:49:14, Pawel Laszczak wrote:
> From: Pawel Laszczak <pawell@xxxxxxxxxxx>
> 
> Patch removes the warning "variable dereferenced before
> check 'pdev->dcbaa'" from cdnsp_mem_cleanup.

You may describe the real problem you fix, but not the warning
message from some auto build system.

> 
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Signed-off-by: Pawel Laszczak <pawell@xxxxxxxxxxx>
> ---
>  drivers/usb/cdns3/cdnsp-mem.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/cdns3/cdnsp-mem.c b/drivers/usb/cdns3/cdnsp-mem.c
> index 5d4c4bfe15b7..a47948a1623f 100644
> --- a/drivers/usb/cdns3/cdnsp-mem.c
> +++ b/drivers/usb/cdns3/cdnsp-mem.c
> @@ -1082,9 +1082,8 @@ void cdnsp_mem_cleanup(struct cdnsp_device *pdev)
>  	dma_pool_destroy(pdev->device_pool);
>  	pdev->device_pool = NULL;
>  
> -	if (pdev->dcbaa)
> -		dma_free_coherent(dev, sizeof(*pdev->dcbaa),
> -				  pdev->dcbaa, pdev->dcbaa->dma);
> +	dma_free_coherent(dev, sizeof(*pdev->dcbaa),
> +			  pdev->dcbaa, pdev->dcbaa->dma);
>  
>  	pdev->dcbaa = NULL;
>  
> -- 
> 2.25.1
> 

-- 

Thanks,
Peter Chen




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux