Hi Valentin, On Mon, Aug 10, 2009 at 02:51:55PM +0200, Valentin Longchamp wrote: > I also tested these patches (the whole series) on mx31moboard and they > work fine. > > Please find a small change to this patch inline to remove some > compilation warnings when using the framework in a board support file. > > Besides this small change, the whole series could (and should) be merged > from my point of view. Many thanks for testing. I would also like to see these patches merged before they don't apply anymore. Is there any objections from the USB folks? I haven't got any reply from that side yet. >> new file mode 100644 >> index 0000000..2c14a18 >> --- /dev/null >> +++ b/include/linux/usb/isp1504.h >> @@ -0,0 +1,6 @@ >> +#ifndef __LINUX_USB_ISP1504_XCVR_H >> +#define __LINUX_USB_ISP1504_XCVR_H >> + >> +extern struct otg_transceiver *otg_isp1504_create(struct otg_io_access_ops *ops); >> + >> +#endif /* __LINUX_USB_ISP1504_XCVR_H */ > > I have changed the above file like that (to remove a warning): > >> #ifndef __LINUX_USB_ISP1504_XCVR_H >> #define __LINUX_USB_ISP1504_XCVR_H >> >> #include <linux/usb/otg.h> >> >> struct otg_transceiver *otg_isp1504_create(struct otg_io_access_ops *ops); >> >> #endif /* __LINUX_USB_ISP1504_XCVR_H */ Ok, agreed. That change is actually small enough to be done on the fly when commiting, right? Or if anyone wants me to send a new patch for that, I can do so. Thanks again, Daniel -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html