Re: [PATCH 2/4] USB OTG: Add driver for NXP's ISP1504 transceiver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Daniel,

I also tested these patches (the whole series) on mx31moboard and they work fine.

Please find a small change to this patch inline to remove some compilation warnings when using the framework in a board support file.

Besides this small change, the whole series could (and should) be merged from my point of view.

Daniel Mack wrote:
This adds a minimal driver for NXP's ISP1504 transceivers, using the OTG
framework functions recently introduced.

Signed-off-by: Daniel Mack <daniel@xxxxxxxx>
Cc: Greg Kroah-Hartman <gregkh@xxxxxxx>
Cc: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx>
Cc: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
Cc: linux-usb@xxxxxxxxxxxxxxx
---
 drivers/usb/Makefile        |    2 +
 drivers/usb/otg/Kconfig     |    6 ++
 drivers/usb/otg/Makefile    |    1 +
 drivers/usb/otg/isp1504.c   |  108 +++++++++++++++++++++++++++++++++++++++++++
 include/linux/usb/isp1504.h |    6 ++
 5 files changed, 123 insertions(+), 0 deletions(-)
 create mode 100644 drivers/usb/otg/isp1504.c
 create mode 100644 include/linux/usb/isp1504.h


snip

diff --git a/include/linux/usb/isp1504.h b/include/linux/usb/isp1504.h
new file mode 100644
index 0000000..2c14a18
--- /dev/null
+++ b/include/linux/usb/isp1504.h
@@ -0,0 +1,6 @@
+#ifndef __LINUX_USB_ISP1504_XCVR_H
+#define __LINUX_USB_ISP1504_XCVR_H
+
+extern struct otg_transceiver *otg_isp1504_create(struct otg_io_access_ops *ops);
+
+#endif /* __LINUX_USB_ISP1504_XCVR_H */

I have changed the above file like that (to remove a warning):

#ifndef __LINUX_USB_ISP1504_XCVR_H
#define __LINUX_USB_ISP1504_XCVR_H

#include <linux/usb/otg.h>

struct otg_transceiver *otg_isp1504_create(struct otg_io_access_ops *ops);

#endif /* __LINUX_USB_ISP1504_XCVR_H */

Best regards,

Val

--
Valentin Longchamp, PhD Student, EPFL-STI-LSRO1
valentin.longchamp@xxxxxxx, Phone: +41216937827
http://people.epfl.ch/valentin.longchamp
MEA3485, Station 9, CH-1015 Lausanne
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux