Hi Thierry, On 25-03-21, 17:40, Thierry Reding wrote: > +static struct tegra_xusb_usb3_port * > +tegra210_lane_to_usb3_port(struct tegra_xusb_lane *lane) > +{ > + int port; > + > + if (!lane || !lane->pad || !lane->pad->padctl) > + return NULL; This looks problematic to me, so if lane is NULL, it will still go ahead and check lane->pad which would result in NULL pointer dereference. -- ~Vinod