On Wed, Mar 17, 2021 at 10:58:24AM -0700, Guenter Roeck wrote: > On 3/17/21 9:42 AM, Greg Kroah-Hartman wrote: > > On Tue, Mar 16, 2021 at 03:52:58PM -0700, Guenter Roeck wrote: > >> On 3/16/21 3:13 PM, Badhri Jagan Sridharan wrote: > >>> This change adds some of the register bit definitions from the TCPCI spec: > >>> https://www.usb.org/sites/default/files/documents/ > >>> usb-port_controller_specification_rev2.0_v1.0_0.pdf > >>> > >>> Signed-off-by: Badhri Jagan Sridharan <badhri@xxxxxxxxxx> > >> > >> Are those going to be used ? > > > > For values and #defines that are in public specs, does it matter? It's > > good to have full definitions in the .h files for whenever possible for > > stuff like this to make it easy for people to write code to use them :) > > > > Good to know your position on this. It is one of the per-maintainer > thingies: Some maintainers don't accept defines if they are not used. > Usually I stay away from defining them to avoid the resulting arguments/ > discussions. If you are ok with it, so am I. #defines are trivial, and are good for documenting things. We have loads of drivers that do this to make it a good way to document the full hardware or specification despite not using all of the defines. They also are not a maintenance burden. I don't take new apis that no one uses in-kernel as that's just ripe for deletion and is a maintenance burden. It makes no sense to add and then remove something right away :) thanks, greg k-h
