On Tue, Mar 16, 2021 at 03:52:58PM -0700, Guenter Roeck wrote: > On 3/16/21 3:13 PM, Badhri Jagan Sridharan wrote: > > This change adds some of the register bit definitions from the TCPCI spec: > > https://www.usb.org/sites/default/files/documents/ > > usb-port_controller_specification_rev2.0_v1.0_0.pdf > > > > Signed-off-by: Badhri Jagan Sridharan <badhri@xxxxxxxxxx> > > Are those going to be used ? For values and #defines that are in public specs, does it matter? It's good to have full definitions in the .h files for whenever possible for stuff like this to make it easy for people to write code to use them :) thanks, greg k-h