On Sat, Mar 06, 2021 at 07:39:09PM +0100, Aaron Dewes wrote: > > > On Sat, Mar 06, 2021 at 06:27:06PM +0100, Aaron Dewes wrote: > > > > On Sat, Mar 06, 2021 at 05:34:32PM +0100, Aaron Dewes wrote: > > > > > Hello! > > > > > > > > > > Sorry if this suggestion/question sounds stupid, I don't have experience > > > > > with the kernel code and this mailing list. > > > > > > > > > > I'm a contributor to Umbrel (getumbrel.com), and we provide a software > > > > > that allows to run a bitcoin node easily, and we've run into many people > > > > > having UAS issues > > > > What specific UAS issues? And why not just fix those instead? > > > Sorry, I should've been more specific. When I said UAS issues, I meant > > > that we've had many users who used drives that were incompatible with > > > UAS, and that script is our way to detect that and fix it, because the > > > kernel apparently often doesn't detect that, and I think that way would > > > be a way to actually automatically detect such issues. > > The kernel _does_ autodetect drives that don't claim to support uas. > > Are you saying that your users have drives which claim to support uas > > but don't actually support it? If that's so, can you tell us what > > drives they are so we can put this information into the kernel? > > This is what we added to cmdline, but the list was too large, so we had > to remove a few for our latest release: > > usb-storage.quirks=152d:1561:u,152d:1576:u,152d:0578:u,125f:a76a:u,04e8:61b6:u,174c:55aa:u,04e8:61f5:u,04e8:4001:u,1058:082a:u,2109:0711:u,152d:0562:u,7825:a2a4:u,04e8:4001:u > > I don't remember all the drives, these were mostly reports from users > who had issues. > > A few ones I could look up in our commit history: > > - JMicron JMS578 and JMS579 > > - Samsung M3 Portable > > - ADATA ED600 > > - PA023U3 > > - A SATA-to-USB adapter sold by "BerryBase", a German RPi-related shop > > This is on kernel 5.4, so some might have already been added. > > To me, it seems like most, if not all devices with the vendor id "152d" > have UAS issues. Care to make up a patch for this so that we can properly blacklist them in the kernel? thanks, greg k-h