On Sat, Mar 06, 2021 at 05:34:32PM +0100, Aaron Dewes wrote:
Hello!
Sorry if this suggestion/question sounds stupid, I don't have experience
with the kernel code and this mailing list.
I'm a contributor to Umbrel (getumbrel.com), and we provide a software
that allows to run a bitcoin node easily, and we've run into many people
having UAS issues
What specific UAS issues? And why not just fix those instead?
Sorry, I should've been more specific. When I said UAS issues, I meant
that we've had many users who used drives that were incompatible with
UAS, and that script is our way to detect that and fix it, because the
kernel apparently often doesn't detect that, and I think that way would
be a way to actually automatically detect such issues.
Currently, drivers/usb/storage/unusual_devs.h disables UAS for a few
devices, but autodetecting would be better in my opinion.
, and we were manually adding quirks in this case. Now
I'm wondering if it is possible to disable UAS for all devices in the
kernel cmdline.
Sure, just blacklist the uas kernel module, that prevents it from being
loaded and hopefully the device will degrade to the
old-school-and-dirt-slow usb-storage protocol.
Have you tried that?
No, but I'll do that.
This is my first question, but I also have another
suggestion. We've developed the following bash script to check for UAS
issues and automatically add quirks:
------
get_uas_string () {
UDEVADM_DATA=$(sudo -u umbrel udevadm test /block/${block_device} 2> /dev/null) # Umbrel is the main user on umbrel, and udevadm doesn't report the vendor id if running as root, which this script is
ID_VENDOR=$(echo "${UDEVADM_DATA}" | grep "ID_VENDOR_ID" | sed 's/ID_VENDOR_ID=//')
ID_MODEL=$(echo "${UDEVADM_DATA}" | grep "ID_MODEL_ID" | sed 's/ID_MODEL_ID=//')
echo "${ID_VENDOR}:${ID_MODEL}:u"
}
if [[ $(dmesg) == *"uas_eh_abort_handler"* ]]; then
echo "External storage might have UAS issues"
UAS_STRING=$(get_uas_string)
if [[ $(cat /boot/cmdline.txt) == *"${UAS_STRING}"* ]]; then
sed "s/usb-storage.quirks=/usb-storage.quirks=$(get_uas_string),/g" -i /boot/cmdline.txt
echo "Rebooting"
sudo reboot
fi
fi
-----
I was wondering if a check like this could be added to the kernel, so
every time uas_eh_abort_handler gets logged, which AFAIK only happens if
UAS has issues, a counter could be increased, so that, if it happens to
often, UAS gets disabled for that drive.
How do you "know" the next time you boot you really have the same drive
or not? That type of logic is best done in userspace, the kernel is
just reporting the issues, it's up to userspace to determine if it wants
to not mount the drive or not.
Okay, I wasn't sure about that.
But back to your root problem, what is wrong with UAS? I've been using
it for a build system for Android for years just fine. And that
stresses the CPU and drive really hard.
thanks,
greg k-h
Thanks for your reply,
Aaron Dewes
