On Tue, Feb 16, 2021 at 07:24:14AM -0800, Guenter Roeck wrote: > On 2/16/21 6:46 AM, Greg Kroah-Hartman wrote: > > The single debugfs file for this driver really is a log file, so make a > > subdir and call it "log" to make it obvious this is what it is for. > > This makes cleanup simpler as we just remove the whole directory, no > > need to handle individual files anymore. > > > > Cc: Guenter Roeck <linux@xxxxxxxxxxxx> > > Cc: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx> > > Cc: linux-usb@xxxxxxxxxxxxxxx > > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > > Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx> > > I'd probably have explored the possibility to group files like this > under the newly created tcpm debugfs directory, but that is really > a nitpick. Good idea, I'll look into doing that next... thanks, greg k-h