On 2/16/21 6:46 AM, Greg Kroah-Hartman wrote:
> The single debugfs file for this driver really is a log file, so make a
> subdir and call it "log" to make it obvious this is what it is for.
> This makes cleanup simpler as we just remove the whole directory, no
> need to handle individual files anymore.
>
> Cc: Guenter Roeck <linux@xxxxxxxxxxxx>
> Cc: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
> Cc: linux-usb@xxxxxxxxxxxxxxx
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>
I'd probably have explored the possibility to group files like this
under the newly created tcpm debugfs directory, but that is really
a nitpick.
Guenter
> ---
> drivers/usb/typec/tcpm/fusb302.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/typec/tcpm/fusb302.c b/drivers/usb/typec/tcpm/fusb302.c
> index ebc46b9f776c..7a2a17866a82 100644
> --- a/drivers/usb/typec/tcpm/fusb302.c
> +++ b/drivers/usb/typec/tcpm/fusb302.c
> @@ -213,8 +213,9 @@ static void fusb302_debugfs_init(struct fusb302_chip *chip)
>
> mutex_init(&chip->logbuffer_lock);
> snprintf(name, NAME_MAX, "fusb302-%s", dev_name(chip->dev));
> - chip->dentry = debugfs_create_file(name, S_IFREG | 0444, usb_debug_root,
> - chip, &fusb302_debug_fops);
> + chip->dentry = debugfs_create_dir(name, usb_debug_root);
> + debugfs_create_file("log", S_IFREG | 0444, chip->dentry, chip,
> + &fusb302_debug_fops);
> }
>
> static void fusb302_debugfs_exit(struct fusb302_chip *chip)
>
