On 2021/02/26 9:00, Shuah Khan wrote: > This patch makes changes to 3 different drivers. Please split these > patches. Makes it easier to revert or fix them. > > Patch1 could add common routines and use them in stud_dev and vudc > Same for usbip_event_lock_killable() and usbip_event_unlock(). > Introduce them in a separate patch. > > __usbip_sockfd_store() could be made common to stub_dev and vudc > similar to usbip_prepare_threads() and usbip_unprepare_threads() > > It will lot easier to review if this large patch is split into > smaller patches. Then, can we apply https://lkml.kernel.org/r/20210205135707.4574-1-penguin-kernel@xxxxxxxxxxxxxxxxxxx as the first patch? It is very easy to review and apply and backport to stable.