On Sat, Feb 20, 2021 at 10:10:03AM +0900, Tetsuo Handa wrote: > On 2021/02/20 1:00, Shuah Khan wrote: > > On 2/19/21 8:53 AM, Greg Kroah-Hartman wrote: > >> What changed from v1? Why isn't that info below the --- line? > >> > >> Please do a v3 with that fixed up. > >> > > > > +1 on this. > > v2 fixed the PTR_ERR() access which was reported in v1 as below. <snip> Great, please add that to the v3 patch when you resubmit it. > > On 2021/02/20 2:10, Julia Lawall wrote: > > From: kernel test robot <lkp@xxxxxxxxx> > > > > PTR_ERR should access the value just tested by IS_ERR > > > > Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci > > > > CC: Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx> > > Reported-by: kernel test robot <lkp@xxxxxxxxx> > > Signed-off-by: kernel test robot <lkp@xxxxxxxxx> > > Signed-off-by: Julia Lawall <julia.lawall@xxxxxxxx> > > > > > Also please run the usbip test on your changes: > > tools/testing/selftests/drivers/usb/usbip/usbip_test.sh > > Too much requirements for me to run that test. I'm not a user of your module. It should be self-contained, what requirements do you see that you do not have? thanks, greg k-h
